Created attachment 179300 [details] Comparison MSO 2010 and LibreOffice 7.4 master Steps to reproduce: 1. Open attachment 83345 [details] from bug 67568 -> The image on top is missing. See comparison image Reproduced in Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 9f0e19721bb598c75835cfa94f4158085f81288e CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: en-US (es_ES.UTF-8); UI: en-US Calc: threaded [Bug found by office-interoperability-tools]
Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=3e7dd04dd8ca1baea4b7918eb7a7080c595c4625 author Hossein <hossein@libreoffice.org> 2022-02-28 00:07:16 +0100 committer Hossein <hossein@libreoffice.org> 2022-03-15 13:00:59 +0100 commit 3e7dd04dd8ca1baea4b7918eb7a7080c595c4625 (patch) tree 385b48cbef6b844f5a1dbaffc8471bafcfb71912 parent 9b6a44a3d58cb050156f6f5253c14f6e0f79eabf (diff) tdf#145614 Convert #define to enum and constexpr Bisected with: bibisect-linux64-7.4 Adding Cc: to Hossein
I guess that failure is related to the yet unresolved comment I added at <https://gerrit.libreoffice.org/c/core/+/124099/11/emfio/inc/mtftools.hxx#285> "tdf#145614 Convert #define to enum and constexpr", "Compared to the original FF_* macro values, these enumerator values are all shifted right 4 bits..."
(In reply to Stephan Bergmann from comment #2) > I guess that failure is related to the yet unresolved comment I added at > <https://gerrit.libreoffice.org/c/core/+/124099/11/emfio/inc/mtftools. > hxx#285> "tdf#145614 Convert #define to enum and constexpr", "Compared to > the original FF_* macro values, these enumerator values are all shifted > right 4 bits..." Hi Stephan, Thanks for the information. @Hossein, could you please give feedback to Stephan's comments, they have been unresolved for more than 2 weeks...
Hossein committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f385661ec1463053c1ca51dc50db075c478de87c tdf#148359 Fix emfio regression: missing emf image It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
With the latest patch, this bug should now be fixed. (In reply to Stephan Bergmann from comment #2) > I guess that failure is related to the yet unresolved comment I added at > <https://gerrit.libreoffice.org/c/core/+/124099/11/emfio/inc/mtftools. > hxx#285> "tdf#145614 Convert #define to enum and constexpr", "Compared to > the original FF_* macro values, these enumerator values are all shifted > right 4 bits..." This is a separate issue, and is addressed with another patch: Fix type, calculation of FamilyFont PitchAndFamily https://git.libreoffice.org/core/commit/51431559bda9a81293d502328982452caeeba6c6