Created attachment 173598 [details] sample file I found this issue while creating a unittest for bug 143320 Steps to reproduce: 1. Open attached document 2. Select all 3. Copy 4. Open new document 5. Paste 6. Undo -> Crash Reproduced in Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 717dc8e3575a18e1e18dc446031e6db4e60a873d CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: x11 Locale: en-US (en_US.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF-dbg, Branch:master, Time: 2021-07-15_06:02:12 Calc: threaded
Created attachment 173599 [details] gdb backtrace
So the reverted commit at bug 143320 may not be the true cause of the crash?
Confirmed in a fresh debug build. This is the assert: sw/source/core/txtnode/ndtxt.cxx:5270: void SwTextNode::TriggerNodeUpdate(const sw::LegacyModifyHint&): Assertion `dynamic_cast<SwTextFormatColl const*>(static_cast<const SwFormatChg*>(pOldValue)->pChangedFormat)' failed.
Created attachment 173762 [details] gdb bt with gen rendering On pc Debian x86-64 with master sources updated today, I could reproduce this.
Michael: thought you might be interested in this one since it concerns Writer + undo.
(In reply to Aron Budea from comment #3) sw::LegacyModifyHint ... isn't Bjoern working in that area?
*** Bug 144716 has been marked as a duplicate of this bug. ***
Unittest added in https://gerrit.libreoffice.org/c/core/+/118908 but still failing
*** Bug 149276 has been marked as a duplicate of this bug. ***
No repro in this debug build: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 0957ee9f5d379c80fca4027c187b471118d0490d CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: CL threaded Xisco/Julien/Aron, can you double-check?
On pc Debian x86-64 with master sources updated today, I don't reproduce this anymore.
yes, it doesn't crash anymore. In fact the unittest <https://gerrit.libreoffice.org/c/core/+/118908> no longer fails either. Closing as RESOLVED WORKSFORME
No repro with steps from bug 144716, so let's close. Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 63e0680e29ea8d414ca23d10304d5564fe2aa99c CPU threads: 8; OS: Linux 6.8; UI render: default; VCL: kf6 (cairo+wayland) Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded
Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/17b2f3d96fb21dcfc2fb8e54ca9670a8c58840f1 tdf#143320, tdf#143387: sw_uiwriter4: Add unittest It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.